-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add Terraform module #64
Conversation
Running
Looking into it |
Following this comment, the charm needs the resource definition for
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mvlassis, I followed your instructions and the charm went to active. Left some comments.
In response to your comment, I think the charm going to error when metacontroller
is not there is a bug, the status should be either blocked
or waiting
I believe. However, this is not related to your change. Can you file an issue about this?
Co-authored-by: Noha Ihab <49988746+NohaIhab@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's backport this once merged!
* Add Terraform module * Update format * Don't run terraform-checks since the charm is missing CRDs on its own * Update terraform/README.md Co-authored-by: Noha Ihab <49988746+NohaIhab@users.noreply.github.com> * Update format for empty map * Add note on why we are skipping the Terraform apply test * Update README.md * Update README.md * Remove channel from terraform action * Update default Terraform channel * Update default Terraform channel * Change the version of the setup operator environment * Change setup operator action tag --------- Co-authored-by: Noha Ihab <49988746+NohaIhab@users.noreply.github.com>
Ref: #63
This PR creates a
terraform/
directory that hosts the Terraform module for this charm. It follows the structure proposed in this spec.To test the module:
tox -e tflint
to ensure that linting is correctterraform/
directory and runterraform init
.terraform apply -var "channel=latest/edge" -var "model_name=kubeflow" --auto-approve
and wait until the charm isActive
andIdle
.