Handle multiple aggregates properly

[pponnuvel]

Currently, if there are multiple aggregates present only the last one is displayed. So the current handling is broken.

This change lists them all so that it be grouped by hypervisors and/or individual aggregate type(s).

Fixes #38.

A different fix was proposed in #57.
But it joins all the aggreates together and they can't be queried, if needed, by aggregate types once joined.

To contrast,

WIth #57, it'd looks like:

hypervisor_vcpus_total{aggregate="aggregate1,different_aggregate,another_one",arch="x86_64",cloud="mycloud",hypervisor_hostname="hypervisor1",nova_service_status="enabled"} 4.0

whereas I am proposing:

hypervisor_vcpus_total{aggregate="aggregate1",arch="x86_64",cloud="mycloud",hypervisor_hostname="hypervisor1",nova_service_status="enabled"} 4.0
hypervisor_vcpus_total{aggregate="different_aggregate",arch="x86_64",cloud="mycloud",hypervisor_hostname="hypervisor1",nova_service_status="enabled"} 4.0
hypervisor_vcpus_total{aggregate="another_one",arch="x86_64",cloud="mycloud",hypervisor_hostname="hypervisor1",nova_service_status="enabled"} 4.0

This is better for querying and also has been requested by a user.

[pponnuvel]

Looks like the master has been renamed to main and #134 was proposed against master because I had an older clone. So closed #134 and created this against main.

cc: @jneo8

[jneo8]

Thanks, LGTM.

[pponnuvel]

Hi there, Is this good to merge?

[jneo8]

Hi @pponnuvel , we need two 2 approving reviews to merge.

[Pjack]

This exporter is only workable under old LMA stack.
Please consider to move to new openstack-exporter which is integrate with COS natively.

[pponnuvel]

This exporter is only workable under old LMA stack. Please consider to move to new openstack-exporter which is integrate with COS natively.

Hi@Pjack, yes, I am aware openstack-exporter supersedes this, and that's been the case for some time. A user insisted that this is a bug and really keen to have this until they migrate to the openstack-exporter. So I am hoping we could get this in until users migrate.

[samuelallan72]

Thanks @pponnuvel . There are currently no tests in CI, so I'm going to have a go at testing this manually.

[pponnuvel]

Thanks @pponnuvel . There are currently no tests in CI, so I'm going to have a go at testing this manually.

I've tested in an environment both with & without aggregates and it's working. Please let me know if you'd like to use mine.

[samuelallan72]

Thanks for confirming testing status. 👍