Alert dict #513
Merged
Alert dict #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstathis
requested review from
sed-i,
Abuelodelanada,
lucabello,
PietroPasotti and
simskij
as code owners
simskij
approved these changes
Aug 25, 2023
|
@dstathis I'm fine merging once the integration test is fixed |
Abuelodelanada
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Partial progress was made on converting prometheus to use the upstream cosl JujuTopology but I missed a few things.
Solution
Fully use JujuTopology from cosl
Testing Instructions
Behavior should not have changed so just general testing.
Release Notes
Now fully uses JujuTopology from cosl