Fix type of StatusBase.name #980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also fixes the type of a subclass's .name attribute, such as BlockedStatus.name, so that a "# type: ignore" comment is not required in such things as "status_str == BlockedStatus.name". See canonical/github-runner-operator#79 (comment)
jdkandersson
approved these changes
Jul 26, 2023
PietroPasotti
approved these changes
Jul 26, 2023
xtrusia
pushed a commit
to xtrusia/operator
that referenced
this pull request
Jul 11, 2024
This also fixes the type of a subclass's .name attribute, such as BlockedStatus.name, so that a "# type: ignore" comment is not required in such things as "status_str == BlockedStatus.name". See canonical/github-runner-operator#79 (comment) (cherry picked from commit fad95d7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes the type of a subclass's .name attribute, such as BlockedStatus.name, so that a "# type: ignore" comment is not required in such things as "status_str == BlockedStatus.name".
See canonical/github-runner-operator#79 (comment)
Please describe the why and the how of your change here.