ci: add integration and state transition tests for the secrets API #2078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimaqq
force-pushed
the
ci-add-secret-tests
branch
2 times, most recently
from
136817b to
c7e97c3
Compare
dimaqq
force-pushed
the
ci-add-secret-tests
branch
from
c7e97c3 to
3f918cb
Compare
dimaqq
commented
Oct 3, 2025
There was a problem hiding this comment.
Here I make the test charm a package, so that the charm class can be imported into Scenario tests without hacks.
It feels a bit ugly, but that's the best way I could come up with.
benhoyt
requested changes
Oct 6, 2025
| - 3.3/stable | ||
| - 3.4/stable | ||
| - 3.5/stable | ||
| - 3.6/stable |
There was a problem hiding this comment.
Do you think we need to run the tests on all of these tracks?
There was a problem hiding this comment.
Today, I'm aware of three version ranges that we must test:
- pre-3.5 (possibly any between 3.1 and 3.4)
- 3.5.5+
- 3.6.0+
I'm thinking to test on a wider variety of Jujus until we've got good secrets API coverage.
At the point, individual tests and their caveats (e.g. juju_version > 3.3.7: assert foo) would allows us to select a more precise set of Juju versions.
WDYT?
|
Alternative PR: dimaqq#74 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High level idea
Run the same series of Ops API calls in unit and integration tests.
This PR