chore: rewrite vendored tracing charm lib in pure Python #2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimaqq
changed the title
dimaqq
commented
Sep 8, 2025
| ) | ||
|
|
||
| for event in ( | ||
| self.charm.on.start, |
There was a problem hiding this comment.
Re-check if start event is neeed, even with bundles.
dimaqq
commented
Sep 8, 2025
|
|
||
| for event in ( | ||
| self.charm.on.start, | ||
| self.charm.on.upgrade_charm, |
There was a problem hiding this comment.
Re-check if upgrade-charm is needed; are relation-related events triggered after charm upgrade, just like start and config-changed.
dimaqq
commented
Sep 8, 2025
| if not rel: | ||
| return Destination(None, None) | ||
|
|
||
| rel.data[self.charm.app]['receivers'] = '["otlp_http"]' |
There was a problem hiding this comment.
Must check leadership first.
|
Based on a chat with Ben, I will reach out to the maintainers of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a Friday item PR.
It's one half of reimplementing vendored charm libs in pure Python.
This PR reimplements the (larger) tracing charm lib.
Not ready for review, but hopefully shows the direction I'm taking.
Fixes #2022
Open question: where to keep the equivalence tests when the vendored code is removed?