Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: note about repeatedly setting secret value in Juju 3.6 #1366

Merged
merged 8 commits into from
Sep 10, 2024

Conversation

dimaqq
Copy link
Contributor

@dimaqq dimaqq commented Sep 6, 2024

@dimaqq
Copy link
Contributor Author

dimaqq commented Sep 6, 2024

@tonyandrewmeyer we don't have a magical "Changed in Juju X.Y" on par with "Added in Juju / Removed in Juju" do we?

@tonyandrewmeyer
Copy link
Contributor

@tonyandrewmeyer we don't have a magical "Changed in Juju X.Y" on par with "Added in Juju / Removed in Juju" do we?

No, but if you look at the end of docs/custom_conf.py you'll see that it's trivial to add.

ops/model.py Outdated Show resolved Hide resolved
@dimaqq
Copy link
Contributor Author

dimaqq commented Sep 9, 2024

Refactored to use custom sphinx markup.

P.S. I'm not too happy with redundancy in "Setting the content with the same content as ..." phrase. Would someone have a better idea?

Copy link
Contributor

@tonyandrewmeyer tonyandrewmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still feels like it belongs in the Juju docs and not the ops docs, but I'm ok with adding it.

tox.ini Show resolved Hide resolved
@dimaqq dimaqq merged commit d3b878e into canonical:main Sep 10, 2024
32 checks passed
@dimaqq dimaqq deleted the secret-value-note branch September 10, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants