Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run tests on Py 3.12 and install test on Py 3.13 #1315

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

dimaqq
Copy link
Contributor

@dimaqq dimaqq commented Aug 15, 2024

Python 3.13 has reached rc1, this PR adds it to the test matrix.

Note: not using free-threaded builds at this point due to actions/setup-python#771 (not like we'd expect any difference, frankly)

Copy link
Collaborator

@benhoyt benhoyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per discussion, we're going to add 3.12 to the places it's missing, but leave 3.13 for now. When 3.13 is out, we'll add it to the pip install block but not for running our tests.

@dimaqq
Copy link
Contributor Author

dimaqq commented Aug 16, 2024

Aside: why do test one artefact, but not the other?

  • dist/ops-<version>.tar.gz is tested
  • dist/ops-<version>-py3-none-any.whl is not tested

Is it because charmcraft pack will use .gz and that's all we care about?

Full disclosure: I believe that the packages are equivalent for install purpose, even though the content is not equivalent: 97 files in a tarball, 26 files in a zip/whl. The differences are our tests, tox.ini, setup.cfg and pyproject.toml.

@dimaqq
Copy link
Contributor Author

dimaqq commented Aug 16, 2024

Updated Python versions per review.

@dimaqq dimaqq requested a review from benhoyt August 16, 2024 05:46
@tonyandrewmeyer
Copy link
Contributor

Aside: why do test one artefact, but not the other?

  • dist/ops-<version>.tar.gz is tested
  • dist/ops-<version>-py3-none-any.whl is not tested

Is it because charmcraft pack will use .gz and that's all we care about?

Full disclosure: I believe that the packages are equivalent for install purpose, even though the content is not equivalent: 97 files in a tarball, 26 files in a zip/whl. The differences are our tests, tox.ini, setup.cfg and pyproject.toml.

Yeah, I think that's the reason why: if we broke installing, it's hard to see how we would break wheel and not sdist or the other way around. The packaging tools could, but probably not something we do. So if there's no point checking both, then we might as well check the one that will be used when packing.

Copy link
Collaborator

@benhoyt benhoyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@dimaqq dimaqq changed the title ci: run tests on Py 3.13 as well ci: run tests on Py 3.12 and install test on Py 3.13 Aug 19, 2024
@dimaqq dimaqq merged commit 828b542 into canonical:main Aug 19, 2024
33 checks passed
@dimaqq dimaqq deleted the ci-py3130 branch August 19, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants