Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 2.15.0 #1295

Merged
merged 3 commits into from
Jul 22, 2024
Merged

chore: 2.15.0 #1295

merged 3 commits into from
Jul 22, 2024

Conversation

dimaqq
Copy link
Contributor

@dimaqq dimaqq commented Jul 22, 2024

No description provided.

@tonyandrewmeyer tonyandrewmeyer changed the title release: 2.15.0 chore: 2.15.0 Jul 22, 2024
Copy link
Contributor

@tonyandrewmeyer tonyandrewmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small suggested tweaks (I should really get in the habit of proposing these when doing the reviews of the actual PRs, so that they're good before we get to release notes).

I think the changelog really ought to mention (link to?) the advisory, though. Even if it's not public when the PR gets merged, as long as it works when the release is done and the advisory is published, that should be fine.

CHANGES.md Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@benhoyt benhoyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed with Tony's feedback (especially having a bit more on check-failed/recovered vents), but approving optimistically.

@dimaqq dimaqq merged commit d46f7e9 into canonical:main Jul 22, 2024
27 checks passed
@dimaqq dimaqq deleted the release-2.15.0 branch July 22, 2024 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants