chore: run ruff format over charm pin update code #1278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A worthy change… was the file excluded from pre commit and/or tox? if so, let’s include it. if it was included , then I’m doubly sorry for having merged it regardless! |
It was included in the formatting but not in the linting. I've added that too, now. |
dimaqq
approved these changes
Jun 27, 2024
IronCore864
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only changes are from running
tox -e fmt, and addingruff format --preview checkto thetox -e lintcommands.I don't think these changes are generally important, being in a separate file only used in CI, but ideally running
tox -e fmtdoesn't bring in unrelated changes when working on a branch, and we might as well be consistent.