Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: release 2.12.0 CHANGES and version #1169

Merged
merged 7 commits into from
Mar 28, 2024
Merged

docs: release 2.12.0 CHANGES and version #1169

merged 7 commits into from
Mar 28, 2024

Conversation

IronCore864
Copy link
Contributor

@IronCore864 IronCore864 commented Mar 28, 2024 •
edited
Loading

Edit CHANGES.md and version.py for release 2.12.0.

@IronCore864 IronCore864 marked this pull request as ready for review March 28, 2024 04:53
@IronCore864 IronCore864 changed the title docs: release 2.12.0 changelog docs: release 2.12.0 CHANGES and version Mar 28, 2024
tonyandrewmeyer
tonyandrewmeyer requested changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@tonyandrewmeyer tonyandrewmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd much rather we did not duplicate the commit types in the bullet points. Please fix HACKING.md if that wasn't clear enough!

CHANGES.md Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
benhoyt
benhoyt reviewed Mar 28, 2024
View reviewed changes
Copy link
Collaborator

@benhoyt benhoyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with Tony's suggestions -- thanks!

IronCore864 and others added 6 commits March 28, 2024 13:13
@IronCore864 @tonyandrewmeyer
Update CHANGES.md
5b0bc19 
Co-authored-by: Tony Meyer <tony.meyer@gmail.com>
@IronCore864 @tonyandrewmeyer
Update CHANGES.md
b3a8a02 
Co-authored-by: Tony Meyer <tony.meyer@gmail.com>
@IronCore864 @tonyandrewmeyer
Update CHANGES.md
6148625 
Co-authored-by: Tony Meyer <tony.meyer@gmail.com>
@IronCore864 @tonyandrewmeyer
Update CHANGES.md
b43cbe7 
Co-authored-by: Tony Meyer <tony.meyer@gmail.com>
@IronCore864 @tonyandrewmeyer
Update CHANGES.md
9bdf8a9 
Co-authored-by: Tony Meyer <tony.meyer@gmail.com>
@IronCore864
chore: move chore to refactor
1465de3
benhoyt
benhoyt approved these changes Mar 28, 2024
View reviewed changes
Copy link
Collaborator

@benhoyt benhoyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now!

@IronCore864 IronCore864 merged commit 2da708a into canonical:main Mar 28, 2024
28 checks passed
@IronCore864 IronCore864 deleted the release-2-12 branch March 28, 2024 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benhoyt benhoyt benhoyt approved these changes

@tonyandrewmeyer tonyandrewmeyer tonyandrewmeyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IronCore864 @tonyandrewmeyer @benhoyt