Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typing): update to latest version of Pyright and fix errors #1105

Merged
merged 4 commits into from
Jan 10, 2024

Commits on Jan 9, 2024

  1. fix(typing): update to latest version of Pyright and fix errors

    So annoying how quickly this tooling changes. Couple of notes:
    
    - ops/charm.py: it seems like the new version disallows overriding the
      type in a subclass, so just use a "pyright: ignore" comment to work
      around this. Maybe there's a better way.
    - The new Pyright no longer allows a type variable to be defined inside
      a function. Not sure what the rationale for this was, but they have
      to be moved to the top level (away from where they're used!) now.
    - Some of the bytes/str/bytearray stuff is annoying. Maybe there are
      better solutions for these types. Oh for Go's io.Reader.
    -
    benhoyt committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    4821301 View commit details
    Browse the repository at this point in the history
  2. Reinstate TYPE_CHECKING check for WeakValueDictionary

    Hopefully this this fixes CI.
    benhoyt committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    4e48d9f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9acd170 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2024

  1. Configuration menu
    Copy the full SHA
    c695917 View commit details
    Browse the repository at this point in the history