Revert changes to Allure in #250 #259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An Allure Report can only be generated for one of the test suite combinations (otherwise results with identical test case IDs will override each other—so any parametrization that pytest is not aware of [because it was done in spread—i.e. juju version, ubuntu base] will result in duplicate test case IDs) Removing the 20.04 base does not change this—we are only able to generate an Allure Report for one of the Juju versions we test with TL;DR the Allure Report should only use tests from a single spread variant. The variant naming was not changed, so the Allure Report config should not have been changed
carlcsaposs-canonical
added
the
not bug or enhancement
sinclert-canonical
approved these changes
May 22, 2025
|
@paulomach could we merge this? I believe the failing test is due to flakiness. |
paulomach
approved these changes
Jun 10, 2025
Yes. @carlcsaposs-canonical , all good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts part of #250
An Allure Report can only be generated for one of the test suite combinations (otherwise results with identical test case IDs will override each other. Any parametrization that pytest is not aware of [because it was done in spread—i.e. juju version, ubuntu base] will result in duplicate test case IDs)
Removing the 20.04 base does not change this—we are only able to generate an Allure Report for one of the Juju versions we test with
TL;DR the Allure Report should only use tests from a single spread variant. The variant naming was not changed, so the Allure Report config should not have been changed