[DPE-6652] Refresh all charm libs #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinclert-canonical
added
the
not bug or enhancement
sinclert-canonical
changed the title
|
@carlcsaposs-canonical any idea why the same 8 tests keep timing out? should we increase the time-outs for those? |
maybe it's related to the changes in the PR? don't see those tests consistently failing on the nightly ci |
After reverting the version update on the charm_tracing.py lib, I see all HA and Upgrade tests passing (see CI run). In order to avoid blocking other updates, and in respect of the time it would take to figure out what is wrong with newer versions of such library, I am going to leave it as is. |
sinclert-canonical
force-pushed
the
sinclert/charm-libs
branch
from
879977c to
4605910
Compare
sinclert-canonical
requested review from
carlcsaposs-canonical,
paulomach,
shayancanonical and
taurus-forever
carlcsaposs-canonical
approved these changes
Feb 28, 2025
shayancanonical
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refreshes all charm libs that have fallen out-of-date, except
charm-tracing(see comment).