Add default 15 second timeout to pebble exec #394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlcsaposs-canonical
requested review from
paulomach,
shayancanonical,
sinclert-canonical and
taurus-forever
|
Opened canonical/mysql-router-operators#20 to improve timeout handling/logging in follow-up PR |
paulomach
approved these changes
Feb 14, 2025
There was a problem hiding this comment.
We do, apparently, need to have default timeout.
Checking all queries the router does, none should take longer under normal conditions, meaning that if get stuck something went wrong and it was acknowledged.
The specific handler in the bug report is idempotent, worth checking if it's the case everywhere a timeout can happen
shayancanonical
approved these changes
Feb 14, 2025
sinclert-canonical
approved these changes
Feb 17, 2025
taurus-forever
approved these changes
Feb 18, 2025
carlcsaposs-canonical
added a commit
to canonical/mysql-router-operator
that referenced
this pull request
Feb 18, 2025
Companion PR to canonical/mysql-router-k8s-operator#394 Use 30 seconds instead of 15 since we aren't constrainted by Kubernetes pod `terminationGracePeriodSeconds`
carlcsaposs-canonical
added a commit
to canonical/mysql-router-operator
that referenced
this pull request
Feb 19, 2025
Companion PR to canonical/mysql-router-k8s-operator#394 Use 30 seconds instead of 15 since we aren't constrainted by Kubernetes pod `terminationGracePeriodSeconds`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes canonical/mysql-router-k8s-operator#393