Skip to content

[gui] Make VM details header wrap w/ window width#5025

Open
sharder996 wants to merge 2 commits into
mainfrom
bugfix/gui-header-wrapping
Open

[gui] Make VM details header wrap w/ window width#5025
sharder996 wants to merge 2 commits into
mainfrom
bugfix/gui-header-wrapping

Conversation

@sharder996

Copy link
Copy Markdown
Collaborator

This PR changes the behaviour of the header which is displayed in the GUI when the shell or instance details page is displayed. The header will now react to the width of the GUI and will wrap the window so that all header elements are always visible.


MULTI-2659

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the VM details header in the Flutter GUI to adapt to available width by wrapping the header’s elements (title, tabs, usage stats, actions) across multiple rows so they remain visible.

Changes:

  • Replaced the single Row-based header layout with a custom MultiChildRenderObjectWidget (_HeaderLayout) that computes 1–3 rows based on width.
  • Introduced layout constants and manual placement logic for aligning the name, tabs, usage stats, and action buttons.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/client/gui/lib/vm_details/vm_details_general.dart
Comment thread src/client/gui/lib/vm_details/vm_details_general.dart Outdated
@codecov

codecov Bot commented Jul 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.56%. Comparing base (408e178) to head (bc880a3).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5025   +/-   ##
=======================================
  Coverage   87.56%   87.56%           
=======================================
  Files         275      275           
  Lines       14668    14668           
=======================================
  Hits        12842    12842           
  Misses       1826     1826           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: ScottH <59572507+sharder996@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 6, 2026 19:58

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

Comment thread src/client/gui/lib/vm_details/vm_details_general.dart
Comment thread src/client/gui/lib/vm_details/vm_details_general.dart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants