[macOS] Instance hostname resolution#5005
Draft
sharder996 wants to merge 17 commits into
Draft
Conversation
Poll and recvfrom() can't be cancelled on destructor, so we add an additional fd that we listen on for a notication to quit the loop.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5005 +/- ##
==========================================
- Coverage 87.77% 87.50% -0.26%
==========================================
Files 273 275 +2
Lines 14678 14691 +13
==========================================
- Hits 12882 12854 -28
- Misses 1796 1837 +41 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a DNS resolver that allows the system's mDNSResponder to forward
.multipassDNS requests to a thread being run by the Multipass daemon.Requests come through a UDP socket and the requested hostname has its IP address queried by the Multipass daemon.
This is an MVP solution that provides most of the functionality of instance hostname resolution, but lacks a few potentially useful features such as IPv6 support and reverse lookups. If this direction was to be closen, some further development would be done along with proper unit testing.