-
Notifications
You must be signed in to change notification settings - Fork 754
[no-merge] Rust prototype #4554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
tobe2098
wants to merge
18
commits into
main
Choose a base branch
from
rust-petname-build
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+752
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous framework required 2 sources of truth for the proper versioning of CXX and cxxbridge-cmd. To avoid such problems, the new build framework will not depend on cxxbridge-cmd.
Due to the inflexibility and the wasted type in copying headers and source to the build/gen directory, this build system has a better approach by not needing any of this and scaffolding wrapper functions on top of its other advantages
Also added comments and file headers
408a85d to
0d0cf6e
Compare
Contributor
Author
|
The current framework testing at runtime is by running multipass launch, which is not very efficient, but since there is no current need for recurrent testing it will stay this way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
Closes # (issue number)
Testing
Unit tests
Manual testing steps:
Screenshots (if applicable)
Checklist
Additional Notes