feat(DPE-6723): LDAP Support #401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gu1nness
force-pushed
the
feat/DPE-6723-integrate-ldap
branch
from
8a70038 to
eb1dcba
Compare
Gu1nness
changed the title
Contributor
Mehdi-Bendriss
left a comment
Mehdi-Bendriss
left a comment
There was a problem hiding this comment.
Thanks Neha, the if/else channel change is not clear to me
| raise_on_blocked=False, | ||
| raise_on_error=False, | ||
| ) | ||
| if channel is None: |
Contributor
There was a problem hiding this comment.
why is the code so duplicated?
Contributor
Author
There was a problem hiding this comment.
It's not duplicated, but there's a bug currently (fixed by this release) that makes the deployment fail to init replicaset from time to time so in order to prevent that we deploy with one and then scale up.
This will be reverted right after that release with the new code that fixes this bug.
Mehdi-Bendriss
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps the mongo single kernel library to support LDAP.