Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPE-2610] Remove support of Juju 2.9 #202

Merged
merged 7 commits into from
Sep 26, 2023
Merged

Conversation

dmitry-ratushnyy
Copy link
Contributor

The goal of this PR is to remove support of Juju 2.9 from the charm.

To do so we are removing code related to handling secrets for juju 2.9

Copy link
Contributor

@MiaAltieri MiaAltieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but dont forget to add

          juju-channel: 3.1/stable
          bootstrap-options: "--agent-version 3.1.5"

to ci or the tests will fail. you can use vm CI as a reference

delgod
delgod previously approved these changes Sep 25, 2023
pyproject.toml Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
Co-authored-by: Mykola Marzhan <303592+delgod@users.noreply.github.com>
dmitry-ratushnyy and others added 2 commits September 26, 2023 08:16
Co-authored-by: Mykola Marzhan <303592+delgod@users.noreply.github.com>
@MiaAltieri MiaAltieri self-requested a review September 26, 2023 07:17
MiaAltieri
MiaAltieri previously approved these changes Sep 26, 2023
@MiaAltieri MiaAltieri self-requested a review September 26, 2023 09:17
@dmitry-ratushnyy dmitry-ratushnyy merged commit 88d41b2 into main Sep 26, 2023
11 checks passed
@dmitry-ratushnyy dmitry-ratushnyy deleted the remove_juju_2.9_support branch September 26, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants