Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPE-2414] Storage reuse #194

Merged
merged 8 commits into from
Aug 31, 2023
Merged

[DPE-2414] Storage reuse #194

merged 8 commits into from
Aug 31, 2023

Conversation

MiaAltieri
Copy link
Contributor

Problem

Current HA Test Suite does not test whether MongoDB properly re-uses storage.

Context

What it means to reuse storage is that when storage is reattached to the juju unit, that the mongo daemon recognises this storage and instead of performing the typical sync from the primary that it instead only syncs what is necessary by computing the diff of what the old storage already has

In Juju versions before 2.9.43, this cannot be tested as there was a bug with storage reuse

Solution

Add a test that tests storage reuse

Copy link

@deusebio deusebio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uhm, I'm not sure how the tests can pass given the typo, or maybe I have misunderstood the code 🤷

Apart from that, code looks all right! Just some small comment and a suggestion

tests/integration/ha_tests/helpers.py Outdated Show resolved Hide resolved
tests/integration/ha_tests/helpers.py Outdated Show resolved Hide resolved
tests/integration/ha_tests/test_ha.py Outdated Show resolved Hide resolved
Copy link

@deusebio deusebio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiaAltieri MiaAltieri merged commit 547ed0c into main Aug 31, 2023
11 checks passed
@MiaAltieri MiaAltieri deleted the storage-reuse branch August 31, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants