-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DPE-1720] Add backups to k8s charm and configure PBM #172
Conversation
808141f
to
2b4d7e0
Compare
51b2ca1
to
b303c3c
Compare
7a8b350
to
9c08694
Compare
0642537
to
8befeaa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is copied from VM charm
b2e486a
to
57b2811
Compare
f07f742
to
16e47fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could use some more refinements
for example? 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! just minor nits and perhaps some questions
95aaf63
Co-authored-by: Mehdi Bendriss <bendrissmehdi@gmail.com>
Address review comment: Remove empty string from ActiveStatus constructor call
2e51fe5
to
61ab709
Compare
About
The goal of this PR is to
Related issues
DPE-1720, DPE-1957