Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: tweaks to navigation headings #264

Merged
merged 3 commits into from
Sep 10, 2024
Merged

docs: tweaks to navigation headings #264

merged 3 commits into from
Sep 10, 2024

Conversation

afgambin
Copy link
Contributor

@afgambin afgambin commented Sep 4, 2024

Some tweaks to update the navigation headings to follow the Diátaxis principles.

@afgambin afgambin requested a review from a team as a code owner September 4, 2024 14:25
@afgambin
Copy link
Contributor Author

afgambin commented Sep 4, 2024

@NohaIhab if you could have a look to this one :)

@canonical canonical deleted a comment from noha Sep 4, 2024
NohaIhab
NohaIhab reviewed Sep 10, 2024
View reviewed changes
Copy link
Contributor

@NohaIhab NohaIhab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comment: this grid looks a bit odd now
I expected it to be left aligned
image

docs/tutorial/mlflow-kubeflow.rst Outdated Show resolved Hide resolved
@afgambin afgambin merged commit 56090e9 into main Sep 10, 2024
8 checks passed
@afgambin afgambin deleted the af-tweaks branch September 10, 2024 11:29
DnPlas added a commit that referenced this pull request Sep 25, 2024
@DnPlas
docs: backport changes introduced in #264
34beaf8 
Backports doc changes from `main` into `track/2.15`:

* 5518500 - fix broken link
* d02260f - docs: tweaks to navigation headings
* 082b161 - some tweaks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NohaIhab NohaIhab NohaIhab approved these changes

Assignees
No one assigned
Labels
Libraries: Out of sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@afgambin @NohaIhab