Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs for 2.15 #260

Merged
merged 7 commits into from
Aug 15, 2024
Merged

Update docs for 2.15 #260

merged 7 commits into from
Aug 15, 2024

Conversation

misohu
Copy link
Member

@misohu misohu commented Aug 14, 2024 •
edited
Loading

Closes: #245, #254, canonical/kserve-operators#262

Changes:

  • MLflow guide
  • MLflow + Kubeflow guide
cd docs 
make run

@misohu misohu requested a review from a team as a code owner August 14, 2024 07:12
rgildein
rgildein reviewed Aug 14, 2024
View reviewed changes
Copy link
Contributor

@rgildein rgildein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only comments, since I do not have full context here.

docs/tutorial/mlflow-kubeflow.rst Outdated Show resolved Hide resolved
docs/tutorial/mlflow-kubeflow.rst Outdated Show resolved Hide resolved
docs/tutorial/mlflow-kubeflow.rst Outdated Show resolved Hide resolved
docs/tutorial/mlflow.rst Show resolved Hide resolved
docs/tutorial/mlflow.rst Show resolved Hide resolved
afgambin
afgambin reviewed Aug 14, 2024
View reviewed changes
docs/tutorial/mlflow.rst Outdated Show resolved Hide resolved
@afgambin
Copy link
Contributor

Did a pass @misohu. Let me know once you address my suggestions and I will do an entire pass of the text. There are some parts I want to change that you didn't modify in this PR (I can also do them in a separate one if we want to merge this one faster).

afgambin
afgambin previously approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@afgambin afgambin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm @misohu from docs side

NohaIhab
NohaIhab reviewed Aug 15, 2024
View reviewed changes
Copy link
Contributor

@NohaIhab NohaIhab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @misohu , left some comments

docs/tutorial/mlflow.rst Show resolved Hide resolved
docs/tutorial/mlflow.rst Outdated Show resolved Hide resolved
docs/tutorial/mlflow.rst Outdated Show resolved Hide resolved
docs/tutorial/mlflow.rst Show resolved Hide resolved
docs/tutorial/mlflow-kubeflow.rst Outdated Show resolved Hide resolved
docs/tutorial/mlflow-kubeflow.rst Show resolved Hide resolved
docs/tutorial/mlflow-kubeflow.rst Outdated Show resolved Hide resolved
docs/tutorial/mlflow-kubeflow.rst Outdated Show resolved Hide resolved
@misohu misohu merged commit be81912 into main Aug 15, 2024
8 checks passed
@misohu misohu deleted the KF-6093-update-docs-for-2-15 branch August 15, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgildein rgildein rgildein left review comments

@NohaIhab NohaIhab NohaIhab approved these changes

@afgambin afgambin afgambin left review comments

Assignees
No one assigned
Labels
Libraries: Out of sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the docs for connecting to MLflow via Kubeflow
4 participants
@misohu @afgambin @rgildein @NohaIhab