Skip to content

Commit

Permalink
Add tests for running UATs
Browse files Browse the repository at this point in the history
  • Loading branch information
misohu committed Sep 25, 2024
1 parent 861d965 commit 8c61abd
Showing 1 changed file with 17 additions and 17 deletions.
34 changes: 17 additions & 17 deletions tests/integration/test_bundle_deployment.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,29 +22,29 @@ def bundle_path() -> str:
class TestCharm:
@pytest.mark.abort_on_fail
async def test_bundle_deployment_works(self, ops_test: OpsTest, lightkube_client, bundle_path):
# # Step 1: Deploy Kubeflow with the specified channel
# subprocess.run(["juju", "deploy", "kubeflow", f"--channel={KUBEFLOW_CHANNEL}", "--trust"], check=True)
# Step 1: Deploy Kubeflow with the specified channel
subprocess.run(["juju", "deploy", "kubeflow", f"--channel={KUBEFLOW_CHANNEL}", "--trust"], check=True)

# # Step 2: Deploy the bundle path
# subprocess.run(["juju", "deploy", bundle_path, "--trust"], check=True)
# Step 2: Deploy the bundle path
subprocess.run(["juju", "deploy", bundle_path, "--trust"], check=True)

# # Step 3: Deploy resource-dispatcher with its channel
# subprocess.run(["juju", "deploy", "resource-dispatcher", f"--channel={RESOURCE_DISPATCHER_CHANNEL}", "--trust"], check=True)
# Step 3: Deploy resource-dispatcher with its channel
subprocess.run(["juju", "deploy", "resource-dispatcher", f"--channel={RESOURCE_DISPATCHER_CHANNEL}", "--trust"], check=True)

# # Step 4: Integrate mlflow-server with resource-dispatcher (secrets and pod-defaults)
# subprocess.run(["juju", "integrate", "mlflow-server:secrets", "resource-dispatcher:secrets"], check=True)
# subprocess.run(["juju", "integrate", "mlflow-server:pod-defaults", "resource-dispatcher:pod-defaults"], check=True)
# Step 4: Integrate mlflow-server with resource-dispatcher (secrets and pod-defaults)
subprocess.run(["juju", "integrate", "mlflow-server:secrets", "resource-dispatcher:secrets"], check=True)
subprocess.run(["juju", "integrate", "mlflow-server:pod-defaults", "resource-dispatcher:pod-defaults"], check=True)

# # Step 5: Integrate mlflow-minio with kserve-controller for object-storage
# subprocess.run(["juju", "integrate", "mlflow-minio:object-storage", "kserve-controller:object-storage"], check=True)
# Step 5: Integrate mlflow-minio with kserve-controller for object-storage
subprocess.run(["juju", "integrate", "mlflow-minio:object-storage", "kserve-controller:object-storage"], check=True)

# # Step 6: Integrate kserve-controller with resource-dispatcher (service-accounts and secrets)
# subprocess.run(["juju", "integrate", "kserve-controller:service-accounts", "resource-dispatcher:service-accounts"], check=True)
# subprocess.run(["juju", "integrate", "kserve-controller:secrets", "resource-dispatcher:secrets"], check=True)
# Step 6: Integrate kserve-controller with resource-dispatcher (service-accounts and secrets)
subprocess.run(["juju", "integrate", "kserve-controller:service-accounts", "resource-dispatcher:service-accounts"], check=True)
subprocess.run(["juju", "integrate", "kserve-controller:secrets", "resource-dispatcher:secrets"], check=True)

# # Step 7: Integrate mlflow-server with istio-pilot and kubeflow-dashboard
# subprocess.run(["juju", "integrate", "mlflow-server:ingress", "istio-pilot:ingress"], check=True)
# subprocess.run(["juju", "integrate", "mlflow-server:dashboard-links", "kubeflow-dashboard:links"], check=True)
# Step 7: Integrate mlflow-server with istio-pilot and kubeflow-dashboard
subprocess.run(["juju", "integrate", "mlflow-server:ingress", "istio-pilot:ingress"], check=True)
subprocess.run(["juju", "integrate", "mlflow-server:dashboard-links", "kubeflow-dashboard:links"], check=True)

# Wait for istio-ingressgateway charm to be active and idle
# This is required because later we'll try to fetch a response from the login url
Expand Down

0 comments on commit 8c61abd

Please sign in to comment.