Repository navigation
ci: add ubuntu-26.04 as a custom runner label so actionlint stops complaining - #5102
Merged
Merged
Conversation
…plaining While ubuntu-26.04 is not actually a custom runner, actionlint v1.7.12 does not know about it.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s actionlint configuration to recognize ubuntu-26.04 as a valid runner label (working around actionlint v1.7.12’s hard-coded runner list), and removes the temporary pre-commit workflow workaround that excluded affected workflows from linting.
Changes:
- Extend
.github/actionlint.yamlrunner-label configuration to acceptubuntu-26.04. - Remove the
pre-commit/actionextra_argsworkaround that filtered outspread.ymlandsymbols-check.yml, allowing them to be linted again.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/pre-commit.yaml |
Drops the explicit --files $(find … -not -name spread.yml …) workaround so pre-commit/action runs with its default behavior and can lint all workflows again. |
.github/actionlint.yaml |
Adds ubuntu-26.04 to the configured runner labels so actionlint v1.7.12 stops flagging it as unknown. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a slightly cleaner version of #5099. The underlying problem is that actionlint v1.7.12 includes a hard coded list of runner images it believes that Github provides, and ubuntu-26.04 is not on that list. Ideally we could move to a newer version in our pre-commit configuration, but no newer versions have been released (there is rhysd/actionlint#683 open to add it though).
We can augment the list of runner images actionlint will treat as valid through it's configuration file though, so that's what this PR does. This has the benefit that we'll be linting the
spread.ymlandsymbols-check.ymlworkflows again, and no change will be necessary if we start using ubuntu-26.04 in other workflows.Closes #5097
How to test
Check if the PreCommit actions workflow succeeds.
Checklist