Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add charming actions #59

Merged
merged 2 commits into from
Jun 2, 2022
Merged

Add charming actions #59

merged 2 commits into from
Jun 2, 2022

Conversation

natalian98
Copy link
Contributor

Charming actions updated according to the ones agreed on template-operator charm.
The aim was to:

  • add release charm action

  • have two publish actions for on: push and on: pull_request:

    • on pull_request, publish to branch no matter if tests passed (tests and publish should run simultaneously)
    • on push, publish to latest/edge only if tests passed
  • avoid re-running the tests on pull_request

  • use reusable workflows in order to avoid duplication of code.

Note: this is a single-charm repo with one resource.

@natalian98 natalian98 requested a review from a team as a code owner June 1, 2022 08:40
@github-actions
Copy link

github-actions bot commented Jun 1, 2022

Libraries are not up to date with their remote counterparts. If this was
not intentional, run charmcraft fetch-libs and commit the updated libs
to your PR branch.

stdout
Library charms.grafana_k8s.v0.grafana_dashboard updated to version 0.11.       
Library charms.prometheus_k8s.v0.prometheus_scrape updated to version 0.19.    

stderr

@DomFleischmann DomFleischmann merged commit daafd9f into master Jun 2, 2022
@DomFleischmann DomFleischmann deleted the add-charming-actions branch June 2, 2022 08:57
jardon added a commit to jardon/minio-operator that referenced this pull request Jun 15, 2022
* Add Prometheus monitoring with Grafana dashboard (canonical#48)

* Add prometheus monitoring relation
* temporarily disable test that uses deprecated feature of ops library

Co-authored-by: Natasha Ho <natasha.ho@canonical.com>

* Add charming actions (canonical#59)

* add charming actions

* update libs

* Add condition to only run publish action if repo owner is canonical

* Add condition to existing if

* Add condition to check-libs

* Move lib-check to merged condition

* Fix typo in condition

* Remove duplicate check-lib

* Add lib-check as prereq for publish-charm

* Remove publish-charm conditions from incorrect merge conflict

* test

Co-authored-by: Natasha Ho <natasha.ho@canonical.com>
Co-authored-by: natalian98 <97316813+natalian98@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants