fix: credential refresh on config change #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: make integration test idempotent * refactor: encapsulate logic for tests, moving connect-to-minio logic into a reusable helper so it can be used by multiple tests * refactor: add arg for access/secret_key in connect_client_to_server * feat: make connection test attempts auto-retry using tenacity.retry * fix: unpin black to fix linting/formatting
* feat: add hash of config to env vars Fixes #47 This adds a hash of the current config to environment variables in order to trigger creating a new pod whenever config changes. This ensures minio will restart whenever someone does `juju config minio access-key=newKey` or similar. This also adds unit tests for the new code Implementation: * refactor handling the default value for secret-key (moved to `_get_secret_key()`) to make it reusable * add `_generate_config_hash()` to create the hash of the current config * fix: _get_secret_key try/except caught wrong exception Fixes bug where we catch errors about missing data in self._stored. Was using `except KeyError`, but `self._stored` raises an `AttributeError` if data is not available. * fix: linting/formatting * feat: Add integration test for credential refresh * fix: test_refresh_credentials Updates test_refresh_credentials to use the refactored connect_client_to_server.
|
All content in this PR was reviewed when merged into this branch, so it should be good to go |
DomFleischmann
approved these changes
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug where changes to Minio's credentials via
juju configwould not be replicated to the Minio workload. Previously, juju config minio access-key something-new would not trigger a restart of the Minio workload, thus not actually change the credentials (unless the pod was later deleted). This PR implements logic to automate this, as well as tests to support it.fixes #47
Other misc changes: