Storage: Recover BTRFS pools source to block device UUID to align with creation process
#13184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomponline
reviewed
Mar 20, 2024
|
Er not sure whats going on with dqlite: |
Yeah I already restarted the jobs, same result. I have checked https://github.com/canonical/dqlite/ and https://github.com/canonical/go-dqlite/ but the last changes are from weeks/months ago. |
…mes out Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
When creating a new storage pool ensure that the config mangling is performed beforehand in FillConfig. This allows other procedures like the recovery to perform config validation without needing to actually create the pool. Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
roosterfish
force-pushed
the
fix_lxd_recover
branch
from
7a5ef1e
to
6aaafed
Compare
tomponline
approved these changes
Mar 21, 2024
tomponline
changed the title
lxd recover for Btrfs backed poolssource to block device UUID to align with creation process
|
Updated PR title to better reflect the change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12605.
This moves the replacement of the pools
sourceproperty from path to its block UUID intoFillConfig(). The recovery procedure can now reconstruct all of the pools config without actually creating the pool using the drivers function.Additionally this addresses an unhandled timeout in 79c1780.