Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth: Remove can_view_configuration entitlement. #13106

Merged
merged 4 commits into from
Mar 12, 2024

Conversation

markylaing
Copy link
Contributor

Additionally, reduce log verbosity on GET requests when the entitlement is can_edit. These are additional checks that are used for conditionally populating configuration only for callers that can edit it.

Closes #13104 (different approach taken after discussion with @tomponline)

Signed-off-by: Mark Laing <mark.laing@canonical.com>
Signed-off-by: Mark Laing <mark.laing@canonical.com>
Signed-off-by: Mark Laing <mark.laing@canonical.com>
… list.

Signed-off-by: Mark Laing <mark.laing@canonical.com>
@markylaing markylaing self-assigned this Mar 12, 2024
Copy link
Member

@tomponline tomponline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have tests to check for config being removed if user doesnt have can_edit on server config (and/or pool/network config)?

@markylaing
Copy link
Contributor Author

markylaing commented Mar 12, 2024

Do we have tests to check for config being removed if user doesnt have can_edit on server config (and/or pool/network config)?

Yes:

edit: I can't see one for networks actually. I can add

@tomponline tomponline merged commit 371aa39 into canonical:main Mar 12, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auth: Log can_view_configuration auth checks at debug level
2 participants