-
Notifications
You must be signed in to change notification settings - Fork 931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auth: Embedded OpenFGA authorization driver #12976
Merged
Merged
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
1746373
lxd/db/cluster: Add a method to get a single entity reference from a …
markylaing e51f12c
gomod: Add OpenFGA dependencies.
markylaing 57b95ea
lxd/db: Adds the OpenFGA datastore implementation.
markylaing be6b406
lxd/auth: Add the OpenFGA model.
markylaing 61ad209
lxd/auth: Add identity provider groups to request details.
markylaing 8389cf5
lxd/auth: Update requestDetails method.
markylaing 74aff1a
lxd/auth: Add the embedded OpenFGA authorization driver.
markylaing 1bbd495
lxd: Load the embedded OpenFGA driver by default.
markylaing 0270135
test: Add a util for getting the fingerprint from a certificate.
markylaing a0fdce4
test/suites: Add tests for fine-grained authorization.
markylaing 28b5fd2
Makefile: Exclude dependency from spec generation.
markylaing File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is pulling in lots of stuff, two surprising items are mysql driver and docker client?
Is it possible for us to consume a more specific package rather than the general openfga package.
Not a blocker ofc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is possible as the go.mod is in the root of the repo. I could look into which specific dependencies are required by the packages we are using and potentially we can write exclude directives to get rid of mysql and docker etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think go mod tidy would have done this for us already if it wasnt needed - i was wondering if we did need to import the main package or whether we can be more specific somehow?