lxd: Add support for apparmor unconfined profile mode #12713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomponline
reviewed
Jan 9, 2024
tomponline
reviewed
Jan 9, 2024
tomponline
reviewed
Jan 9, 2024
tomponline
reviewed
Jan 9, 2024
There was a problem hiding this comment.
Thanks @alexmurray
Could you advise what combination of kernel/ubuntu release and snapd version is needed to use the new "(unconfined)" profiles?
|
AppArmor unconfined profile mode is supported in the kernel in Ubuntu 23.10 and 24.04 whilst for snapd this is currently only in snapd edge/master. |
tomponline
reviewed
Jan 9, 2024
This should be treated the same as being in the unconfined profile. Signed-off-by: Alex Murray <alex.murray@canonical.com>
Allow dnsmasq to be restarted / killed and remove the peer restriction on the signal rule for the archive profile to ensure it can be sent by a lxd which is confined under a profile with the unconfined flag. Signed-off-by: Alex Murray <alex.murray@canonical.com>
Signed-off-by: Alex Murray <alex.murray@canonical.com>
alexmurray
force-pushed
the
add-support-for-apparmor-unconfined-profile-mode
branch
from
54268e7
to
e6901cd
Compare
tomponline
reviewed
Jan 9, 2024
There was a problem hiding this comment.
LGTM!
Confirmed with @alexmurray separately that this will need to be landed in LXD (and the 5.0 LTS series) in order to be compatible with forthcoming snapd 2.62 release (that contains canonical/snapd#13333). Otherwise LXD won't work.
tomponline
approved these changes
Jan 18, 2024
6 tasks
tomponline
added a commit
to tomponline/lxd-pkg-snap
that referenced
this pull request
Feb 1, 2024
Cherry-picks canonical/lxd#12713 Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unconfined profile mode adds
(unconfined)to the profile label and is now used in snapd for lxd since canonical/snapd#13333 was merged recently. lxd needs to treat this the same as the "unconfined" label used previously AND we also add a couple required signal rules and remove any peer restriction - this allows LXD to work as expected again in snapd.