Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Ensure the remote connection using simplestreams is valid before adding it" #12446

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Revert "Ensure the remote connection using simplestreams is valid before adding it" #12446

merged 2 commits into from
Oct 24, 2023

Conversation

tomponline
Copy link
Member

Reverts #12442 as it prevented adding simplestreams remotes.

@tomponline
Revert "lxc: check host/port and URL path connectivity when adding a …
575610b 
…simplestreams remote"

This reverts commit 3711df7.

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
@tomponline
Revert "test: test bad connectivity when adding a simplestreams remote"
46ad0b7 
This reverts commit 17cbce8.

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
@tomponline tomponline self-assigned this Oct 24, 2023
@tomponline tomponline mentioned this pull request Oct 24, 2023
Closed
@tomponline tomponline merged commit 6d817d1 into canonical:main Oct 24, 2023
25 checks passed
@tomponline tomponline deleted the tp-revert-remote-add branch October 24, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MusicDin MusicDin MusicDin approved these changes

@gabrielmougard gabrielmougard Awaiting requested review from gabrielmougard

Assignees

@tomponline tomponline

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomponline @MusicDin