lxd/instance/drivers: Check running status with InitPID for cgroups
#12441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cgroup storage limits are not applied when the container starts up. That is because `IsRunning` returns `false` during the container startup. This commits fixes this issue by relying on `InitPID` instead of `IsRunning`. The former will return a positive integer if the container is running even if the container is not fully set up yet. Fixes canonical#12343 Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
tomponline
approved these changes
Oct 23, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cgroup storage limits are not applied when the container starts up. That
is because
IsRunningreturnsfalseduring the container startup.This commits fixes this issue by relying on
InitPIDinstead ofIsRunning. The former will return a positive integer if the containeris running even if the container is not fully set up yet.
Fixes #12343