Fix volume rename if cluster desination target is set #12410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is set This fixes a regression introduced in canonical#12348 which causes the `--destination-target` flag to be ignored. When renaming a volume using `lxc storage volume move`, the args were passed to the handler behind `lxc storage volume rename` which does not support the `--destination-target` flag. Instead if the destination flag is set when renaming a volume, use the handler for volume movements. Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
tomponline
approved these changes
Oct 18, 2023
|
In the meantime cluster tests are running fine on my fork https://github.com/roosterfish/lxd/actions/runs/6559619100 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression introduced in #12348
which causes the
--destination-targetflag to be ignored.When renaming a volume using
lxc storage volume move, the args werepassed to the handler behind
lxc storage volume renamewhich does notsupport the
--destination-targetflag.Instead if the destination flag is set when renaming a volume, use the handler for volume movements.