Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: Test the distribution tarball can be used to build LXD and its dependencies #12248

Merged
merged 2 commits into from
Sep 13, 2023
Merged

tests: Test the distribution tarball can be used to build LXD and its dependencies #12248

merged 2 commits into from
Sep 13, 2023

Conversation

tomponline
Copy link
Member

@tomponline tomponline commented Sep 13, 2023 •
edited
Loading

Closes #12194
Closes #12183

@MusicDin @tomponline
Makefile: Allow setting custom version
6408fa8 
Signed-off-by: Din Music <din.music@canonical.com>
@tomponline tomponline self-assigned this Sep 13, 2023
@MusicDin @tomponline
actions: Test LXD tarball is produced correctly
9134751 
Signed-off-by: Din Music <din.music@canonical.com>
@tomponline tomponline marked this pull request as ready for review September 13, 2023 12:59
@tomponline
Copy link
Member Author

@MusicDin sudo always removes LD_LIBRARY_PATH, so we need to invoke go test with LD_LIBRARY_PATH=${LD_LIBRARY_PATH}

@tomponline tomponline changed the title tests: Ensure LXD tarball is produced correctly tests: Test the distribution tarball can be used to build LXD and its dependencies Sep 13, 2023
MusicDin
MusicDin approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@MusicDin MusicDin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it makes sense. Thanks :)

@MusicDin
Copy link
Member

I have already approved.

@tomponline tomponline merged commit 5f98389 into canonical:main Sep 13, 2023
24 checks passed
@tomponline tomponline deleted the tp-dist branch September 13, 2023 13:17
@MusicDin
Copy link
Member

Perfect, I see it worked 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MusicDin MusicDin MusicDin approved these changes

Assignees

@tomponline tomponline

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release tarball format
2 participants
@tomponline @MusicDin