doc: Update IPAM cli output to use documentation-specific IP addresses #12060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielmougard
force-pushed
the
fix/ipam-doc-2
branch
from
c6efc94
to
ab64be1
Compare
gabrielmougard
force-pushed
the
fix/ipam-doc-2
branch
from
ab64be1
to
afff060
Compare
tomponline
requested changes
Jul 21, 2023
ru-fu
reviewed
Jul 21, 2023
|
@gabrielmougard whats the status of this? |
|
It was in a stale state as a worked on the doc. I'll address the comments now |
gabrielmougard
force-pushed
the
fix/ipam-doc-2
branch
from
afff060
to
2cda27b
Compare
|
@ru-fu @tomponline updated |
tomponline
reviewed
Jul 31, 2023
doc/howto/network_ipam.md
Outdated
| +----------------------+-------------------+----------+------+-------------------+ | ||
| | /1.0/instances/u1 | ::ffff:a00:79/128 | instance | true | 00:16:3e:04:f0:95 | | ||
| +----------------------+-------------------+----------+------+-------------------+ | ||
| | /1.0/instances/u1 | 10.0.0.121/32 | instance | true | 00:16:3e:04:f0:95 | |
There was a problem hiding this comment.
This should be part of 192.0.2.0/24 right?
There was a problem hiding this comment.
oops yes of course
tomponline
reviewed
Jul 31, 2023
doc/howto/network_ipam.md
Outdated
| +----------------------+-------------------+----------+------+-------------------+ | ||
| | /1.0/networks/lxdbr0 | 2001:db8::/32 | network | true | | | ||
| +----------------------+-------------------+----------+------+-------------------+ | ||
| | /1.0/instances/u1 | ::ffff:a00:79/128 | instance | true | 00:16:3e:04:f0:95 | |
There was a problem hiding this comment.
This isn't part of 2001:db8::/32
gabrielmougard
force-pushed
the
fix/ipam-doc-2
branch
from
2cda27b
to
3f05bca
Compare
Signed-off-by: Gabriel Mougard <gabriel.mougard@canonical.com>
gabrielmougard
force-pushed
the
fix/ipam-doc-2
branch
from
3f05bca
to
c538eef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.