Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jupyter-web-app ROCK fails to build #41

Closed
i-chvets opened this issue Aug 16, 2023 · 1 comment
Closed

Jupyter-web-app ROCK fails to build #41

i-chvets opened this issue Aug 16, 2023 · 1 comment

Comments

@i-chvets
Copy link
Contributor

i-chvets commented Aug 16, 2023 •
edited
Loading

Bug Description

Jupyter web app ROCK fails to build. It has been updated during workshop and was not validated since then.

To Reproduce

In jupyter-web-app execute rockcraft pack --verbosity=trace

Envrionment

Regular development environment with lxd and rockcraft installed.

Relevant Log Output

Failure:

cp: cannot stat '/root/parts/kubeflow-repo/src/components/crud-web-apps/common/backend/*': No such file or directory

Full log

Additional Context

The following updates are required to this ROCK:

  • Investigte why source code is not being checkout properly.
  • Add run-user non-root user setup
  • Remove old non-user setup.
  • Update sequrity team requirements, if needed.
i-chvets pushed a commit that referenced this issue Aug 16, 2023
fix: removed jupyter-web-app
9a5e3f7 
Summary of changes:
- Removed jupyter-web-app due to #41
i-chvets pushed a commit that referenced this issue Aug 17, 2023
fix: update jupyter web app rock
2bbdc84 
#41

Summary of changes:
- Added run-user non-root user setup
- Remove old non-user setup.
- Update sequrity team requirements.
- Re-implemented as multi-part rock.
@i-chvets i-chvets mentioned this issue Aug 17, 2023
Merged
i-chvets added a commit that referenced this issue Aug 23, 2023
@i-chvets
fix: update jupyter web app rock (#42)
b3a67f1 
* fix: update jupyter web app rock
#41

Summary of changes:
- Added run-user non-root user setup
- Remove old non-user setup.
- Update sequrity team requirements.
- Re-implemented as multi-part rock.
- Updated rock to copy artifacts directlu into part install to avoid
  unneccessary copy (code review suggestion)
- Added PYTHONPATH to service to ensure service starts properly.
@DnPlas
Copy link
Collaborator

DnPlas commented Jan 29, 2024 •
edited
Loading

This is an old issue that I tried to reproduce w/o success. The rockcraft project has changed a lot since Aug 2023, and the reported error is not happening anymore, however, rockcraft introduced recent changes like requiring a certain format for the version and base, which prevents the rocks as they are right now to be actually built.
I'm closing this issue because it is not reproducible anymore, and opening a new one to track the most updated error messages we get at build time.

EDIT: we have filed issues (enhancements) for updating the rockcraft projects:
#63
#64
#65
#66
#67

@DnPlas DnPlas closed this as completed Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
MLOps Solution Issues
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DnPlas @i-chvets