-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: refactor certs generation and add tests #104
Conversation
- moved gen_certs to certs.py - added gen_certs_if_missing - test gen_certs_if_missing - remove unneeded mocked_gen_certs fixture
Is this PR still in work? I see some test failures but I don't think this landed elsewhere |
@ca-scribner |
do we want to close this in favor of using tls operator? |
We need to finish it, so kserve can function. What's left? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @NohaIhab, few comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @NohaIhab
Summary: