build: refactor charmcraft.yaml to use ST124 notation #282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor charmcraft.yaml files to enable the usage of charmcraft-cache and data-platform-workflows in general. Close #271
NohaIhab
reviewed
Jan 30, 2025
There was a problem hiding this comment.
hey @orfeas-k, can you add the license to every charm directory so it can be staged? see canonical/kubeflow-tensorboards-operator#158 for example. Other than that, LGTM.
NohaIhab
approved these changes
Jan 30, 2025
orfeas-k
added a commit
that referenced
this pull request
Feb 3, 2025
* build: refactor charmcraft.yaml to use ST124 notation (#282) Refactor charmcraft.yaml files to enable the usage of charmcraft-cache and data-platform-workflows in general. Close #271 * refactor(ci): use data-platform-workflows in on_pull/push workflows (#284) * refactor(ci): use data-platform-workflows in on_pull/push workflows * Enable the usage of `build_charm.yaml` workflow, which allows independent and cached charm builds, making the CI more efficient and fast. * Refactor the tests and the integrate workflow to be able to use the charm artefacts generated by the `build_charm.yaml` workflow: - Refactor integrate.yaml to be ci.yaml, a workflow that now takes care for the whole pipeline from generating charm paths, to building, to testing, and then releasing. This change will replace on_pull_request.yaml. - on_push.yaml is now replaced entirely by release, which will run on pushes to main or track/* branches. This workflow is in charge of building -> testing -> releasing. - Refactor individual and repository level integration tests to be able to use charm artefacts besides building them. Close #272 * refactor(ci): Replace release.yaml with promote.yaml (#285) * Add promote.yaml workflow to replace the old release.yaml workflow_dispatch funcionality. * Remove publish.yaml workflow as the release process is handled by the recently refactor release.yaml. Fix #277
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor charmcraft.yaml files to enable the usage of charmcraft-cache and data-platform-workflows in general. See issue for details
Close #271
Note that: