feat: Add terraform modules for knative-{eventing,operator,serving} #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orfeas-k
added a commit
that referenced
this pull request
Sep 24, 2024
…227) Create a `terraform/` directory for each of the charms to host their individual Terraform modules. It follows the structure proposed in [this spec](https://docs.google.com/document/d/1EG71A2pJ244PQRaGVzGj7Mx2B_bzE4U_OSqx4eeVI1E/edit) and it is based on what was done in canonical/argo-operators#198. Ref #224 Ref #225 Ref #226
orfeas-k
added a commit
that referenced
this pull request
Sep 26, 2024
…ules
feat: Backport terraform modules for knative-{eventing,operator,serving} from #227
This was referenced Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a
terraform/directory for each of the charms to host their individual Terraform modules. It follows the structure proposed in this spec and it is based on what was done in canonical/argo-operators#198.To test the modules:
cdinto its directorytox -e tflintto ensure that linting is correctkubeflowterraform apply -var "channel=latest/edge" -var "model_name=kubeflow" --auto-approveand wait until the charm isActiveandIdle. Note that eventing and serving won't go to active because ofknative-servingerror applying manifests whenknative-operatoris not done installing #156.CI
This should be merged after canonical/charmed-kubeflow-workflows#64. This disables the
terraform applyjob due to #156.Ref #224
Ref #225
Ref #226