Support functionality to override default images for kfp-profile-controller #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misohu
force-pushed
the
KF-5476-fix-customisable-images-profile-controller
branch
from
c23bb79
to
feb5048
Compare
ca-scribner
requested changes
Apr 3, 2024
There was a problem hiding this comment.
Minor comments but otherwise lgtm
Is there anything more we should do to demonstrate that this PR solves canonical/bundle-kubeflow#851? We demonstrate that the pods in the user namespace come up with the updated images, so I think that's enough? We could test in airgapped, but I think that is overkill... wdyt?
misohu
force-pushed
the
KF-5476-fix-customisable-images-profile-controller
branch
from
d85fa16
to
a86ef44
Compare
|
Thanks @ca-scribner for your review I resolved your comments. I dont think airgapped is needed for now (yes it will be overkill). Moreover I believe the proposed integration test is handling the problem from the issue. It demonstrates that if you change the config, desired images will be deployed with new profiles. |
This was referenced Apr 5, 2024
ca-scribner
reviewed
Apr 10, 2024
ca-scribner
reviewed
Apr 10, 2024
ca-scribner
requested changes
Apr 10, 2024
ca-scribner
reviewed
Apr 11, 2024
ca-scribner
previously approved these changes
Apr 11, 2024
There was a problem hiding this comment.
lgtm, but CI is failing due to this charmcraft issue. That should be fixed ~today by charmcraft 2.6.0, and we should rerun CI once that ships to confirm everything works.
ca-scribner
approved these changes
Apr 12, 2024
NohaIhab
pushed a commit
that referenced
this pull request
May 9, 2024
switch to jlumbroso/free-disk-space for freeing runner space (#428) The previous space freeing method (easimon/maximize-build-space) at some point circa 2024-01 stopped freeing as much space, likely due to changes in the runner (~29GB free after it freed space). Not sure why this happened, but jlumbroso/free-disk-space at time of this commit would get us up to ~45GB free on the runner without negative effects so we've switched to that. Support functionality to override default images for kfp-profile-controller (#416) * Support functionality to override default images for kfp-profile-controller ci: remove destructive mode from integration tests (#441) The charmcraft issues that forced us to use destructive mode are now fixed. build: install `jinja2` from binary (#443) This commit installs jinja2 (an install dependency of charmed-kubeflow-chisme) as a binary to avoid running into the build time issues described in canonical/bundle-kubeflow#883. Part of canonical/bundle-kubeflow#883 refactor: use k8s_service_info lib instead of SDI (#436) * refactor: use k8s_service_info lib instead of SDI Use the k8s_service_info for receiving the MLMD GRPC Service info instead of using the SDI, as it will stop being supported soon. This commit also ensures that mlmd runs with trust=True in the integration tests. Fixes #413 fix: Pin integration test dependencies in main (#434) * pin integration test dependencies Co-authored-by: Daniela Plascencia <daniela.plascencia@canonical.com> feat: Integrate ROCK in metadata-writer charm (#439) chore: Bump o11y libs and remove obsolete juju topology (#446) Ref canonical/bundle-kubeflow#880 Ref canonical/bundle-kubeflow#849 ci: bump juju to 3.5
NohaIhab
pushed a commit
that referenced
this pull request
May 24, 2024
…roller (#416) * Support functionality to override default images for kfp-profile-controller
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes canonical/bundle-kubeflow#851
New functionality:
ui-artifactandvisualizationserverpods through custom-images config setting.CI passes except bundle tests which was previously observed in #399