refactor kfp-api's on_remove to use KRH built-in delete #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ca-scribner
force-pushed
the
KF-4984-use-krh-delete-on-remove
branch
from
3e3cfee
to
9d08c37
Compare
ca-scribner
commented
Nov 17, 2023
github-actions
bot
added
Libraries: OK
Libraries: Out of sync
and removed
Libraries: Out of sync
Libraries: OK
labels
|
LGTM I see kfp-api integration failing because of mysql error fixed with this #386 just the bundle test is failing on |
DnPlas
force-pushed
the
1.8-updates-dev-branch
branch
from
1572e69
to
207ddfe
Compare
8 tasks
|
We will rebase and retarget this on main after #362 is merged |
Refactors kfp-api charm's `on_remove()` event handler to use KubernetesResourceHandler.delete() rather than its own removal procedure. This was done to: * use the same removal procedure as other charms * remove the need for the `on_remove()` handler to have a KRH object with full context (in future we will add another Kubernetes object here that requires relation data to render, but the relation data is not guaranteed to be available during remove)
ca-scribner
force-pushed
the
KF-4984-use-krh-delete-on-remove
branch
from
f6a6db8
to
2abf848
Compare
|
PR has been rebased on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors kfp-api charm's
on_remove()event handler to use KubernetesResourceHandler.delete() rather than its own removal procedure. This was done to:on_remove()handler to have a KRH object with fullcontext. In future we will add another Kubernetes object here that requires relation data to render, and this relation data may not be available during the removal event