fix: revert updateStrategy of secrets to InPlace (#395)

canonical · Dec 1, 2023 · 0f298b3 · 0f298b3
1 parent 7b3a225
commit 0f298b3
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/charms/kfp-profile-controller/src/templates/crd_manifests.yaml.j2 b/charms/kfp-profile-controller/src/templates/crd_manifests.yaml.j2
@@ -1,5 +1,6 @@
 # Source manifests/apps/pipeline/upstream/base/installs/multi-user/pipelines-profile-controller/composite-controller.yaml
 # Change resyncPeriodSeconds to 1 hour from insane 20 seconds
+# Change updateStrategy of secrets to InPlace to update on changing minio secret
 # Only  sync namespaces with pipelines.kubeflow.org/enabled = "true"
 apiVersion: metacontroller.k8s.io/v1alpha1
 kind: DecoratorController
@@ -10,7 +11,8 @@ spec:
   - apiVersion: v1
     resource: secrets
     updateStrategy:
-      method: OnDelete
+    # updateStrategy is set to InPlace, unlike OnDelete in upstream, to update on changing minio secret
+      method: InPlace
   - apiVersion: v1
     resource: configmaps
     updateStrategy: