refactor: remove memoised Redux selectors #1892
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demo
Jenkins 
demos.haus 
andogq
force-pushed
the
refactor/redux-selectors
branch
from
c70c84e to
ec58b2d
Compare
huwshimi
approved these changes
Mar 14, 2025
huwshimi
added
Review: QA +1
Review: Code +1 (with changes)
and removed
Review: QA needed
Review: Code needed
labels
- update all instances of `useSelector` to `useAppSelector` - update one test in `ModelTableList.test.tsx` which relied on spying on a memoised selector
andogq
force-pushed
the
refactor/redux-selectors
branch
from
ec58b2d to
6122db8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
update all instances of
useSelectortouseAppSelectorupdate one test in
ModelTableList.test.tsxwhich relied on spying on a memoised selectorQA
Details