fix: prevent action log modal from breaking out of stacking context #1883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demo
Jenkins 
demos.haus 
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
huwshimi
approved these changes
Mar 11, 2025
src/pages/EntityDetails/Model/Logs/ActionLogs/_action-logs.scss
Outdated
Show resolved
Hide resolved
huwshimi
added
Review: QA +1
Review: Code +1 (with changes)
and removed
Review: QA needed
Review: Code needed
labels
- render modal inside `Portal`
- add to framer element:
- `position` to create a new stacking context which the modal can't
break out of
- `z-index` to imitate Vanilla's modal backdrop
andogq
force-pushed
the
fix/1784-action-modal
branch
from
e010acb to
88c89e6
Compare
|
Ready to merge, pending juju-dashboard release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
Feels a little bit wacky, but the issue boils down to elements with an opacity != 0 will create a new stacking context, meaning the z-index set within for the backdrop doesn't interact with the rest of the page (eg navigation bars)
render modal inside
Portaladd to framer element:
positionto create a new stacking context which the modal can't break out ofz-indexto imitate Vanilla's modal backdropQA
dotrun clean && dotrun serveDetails
Screenshots
Screen.Recording.2025-03-11.at.16.27.54.mov