Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Remove ui slice from Redux store #1838

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

Ninfa-Jeon
Copy link
Contributor

Done

Removes the ui slice and its associated logic from the Redux store.

QA

  • Tests should pass

Details

https://warthogs.atlassian.net/browse/WD-18339

@webteam-app
Copy link

@Ninfa-Jeon Ninfa-Jeon self-assigned this Jan 24, 2025
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.04%. Comparing base (08b842e) to head (e61e95c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1838      +/-   ##
==========================================
- Coverage   98.04%   98.04%   -0.01%     
==========================================
  Files         199      197       -2     
  Lines       14713    14692      -21     
  Branches     2720     2717       -3     
==========================================
- Hits        14426    14405      -21     
  Misses        287      287              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@steverydz steverydz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Ninfa-Jeon Ninfa-Jeon merged commit e467ef3 into canonical:main Jan 24, 2025
10 checks passed
@Ninfa-Jeon Ninfa-Jeon deleted the remove-unused-redux branch January 24, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants