feat: display login from rebac admin pages #1833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demo
Jenkins 
demos.haus 
|
Requires #1831 to merge first. |
huwshimi
force-pushed
the
rebac-display-login
branch
from
b87d370 to
39a35c1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1833 +/- ##
==========================================
- Coverage 99.26% 98.04% -1.22%
==========================================
Files 378 199 -179
Lines 42504 14713 -27791
Branches 5149 2720 -2429
==========================================
- Hits 42190 14426 -27764
+ Misses 314 287 -27 ☔ View full report in Codecov by Sentry. |
huwshimi
force-pushed
the
rebac-display-login
branch
from
39a35c1 to
9700ab8
Compare
Ninfa-Jeon
requested changes
Jan 23, 2025
huwshimi
force-pushed
the
rebac-display-login
branch
from
9700ab8 to
34e430e
Compare
Ninfa-Jeon
added
Review: QA +1
Review: Code +1
and removed
Review: QA needed
Review: Code needed
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
QA
Details
https://warthogs.atlassian.net/browse/WD-18187