Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: sync version in rockcraft.yaml when release #97

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Conversation

wood-push-melon
Copy link
Contributor

We would like to publish the ROCK image with the tagged version whenever there is a new release. But this had been accomplished. This pull request will further improve the release flow which will sync the tagged version to the rockcraft.yaml file. It also includes some cleanups in the GitHub actions.

@wood-push-melon wood-push-melon requested a review from a team as a code owner July 18, 2023 02:10
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #97 (aaac1c8) into main (2105183) will not change coverage.
The diff coverage is n/a.

❗ Current head aaac1c8 differs from pull request most recent head 8ffd6d7. Consider uploading reports for the commit 8ffd6d7 to get more accurate results

@@           Coverage Diff           @@
##             main      #97   +/-   ##
=======================================
  Coverage   77.09%   77.09%           
=======================================
  Files           9        9           
  Lines         550      550           
=======================================
  Hits          424      424           
  Misses        110      110           
  Partials       16       16           

Copy link
Contributor

@nsklikas nsklikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, LGTM. Only a minor comment about the workflow's job.step, which you can disregard

.github/workflows/publish.yaml Outdated Show resolved Hide resolved
@shipperizer shipperizer self-requested a review July 18, 2023 14:54
@wood-push-melon wood-push-melon changed the title feat: sync version in rockcraft.yaml when release ci: sync version in rockcraft.yaml when release Jul 19, 2023
@wood-push-melon
Copy link
Contributor Author

Did a squash and forced push for using ci instead of feat in the commit message.

@shipperizer shipperizer merged commit 73b53f2 into main Jul 19, 2023
8 checks passed
@shipperizer shipperizer deleted the IAM-274 branch July 19, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants