Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle more kratos error codes #280

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Handle more kratos error codes #280

merged 1 commit into from
Sep 12, 2024

Conversation

natalian98
Copy link
Contributor

fixes #276

@natalian98 natalian98 requested a review from a team as a code owner September 11, 2024 14:34
shipperizer
shipperizer previously approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@shipperizer shipperizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be good to eventually get a test for the ui errors

@natalian98 natalian98 requested review from shipperizer and a team September 11, 2024 15:31
shipperizer
shipperizer previously approved these changes Sep 11, 2024
View reviewed changes
nsklikas
nsklikas previously approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@nsklikas nsklikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approving this to move forward. BUT as I mentioned in the issue as well, I think we will need to go through all the Kratos errors and create a (nearly) exhaustive mapping. Adding an error code every time one pops up does not scale very well.

pkg/kratos/service.go Show resolved Hide resolved
pkg/kratos/service.go Outdated Show resolved Hide resolved
@natalian98
Copy link
Contributor Author

I am approving this to move forward. BUT as I mentioned in the issue as well, I think we will need to go through all the Kratos errors and create a (nearly) exhaustive mapping. Adding an error code every time one pops up does not scale very well.

I went through the list of codes. Some of them are already mitigated by validation done on frontend (e.g. password requirements), others make no value to the end user.

@natalian98 natalian98 mentioned this pull request Sep 12, 2024
Open
@natalian98 natalian98 merged commit 6099d68 into main Sep 12, 2024
6 checks passed
@natalian98 natalian98 deleted the IAM-1040-error-codes branch September 12, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shipperizer shipperizer shipperizer approved these changes

@nsklikas nsklikas nsklikas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unknown error code on invalid totp
3 participants
@natalian98 @shipperizer @nsklikas